Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile balance cover/transfer/rollover overspending #1802

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Mobile balance cover/transfer/rollover overspending #1802

merged 9 commits into from
Oct 30, 2023

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Oct 16, 2023 •
edited
Loading

Add the following tooltip options in mobile balance:

  • Transfer to another category
  • Rollover overspending
  • Cover overspending

@netlify
Copy link

netlify bot commented Oct 16, 2023 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6b86184
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/653df8292be2440008ff7c09
😎 Deploy Preview https://deploy-preview-1802.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.83 MB (+7.13 kB) +0.25%
Changeset
File Δ Size
src/components/budget/rollover/BalanceTooltip.tsx 🆕 +3.11 kB 0 B → 3.11 kB
src/components/budget/rollover/CoverTooltip.tsx 🆕 +2.43 kB 0 B → 2.43 kB
src/components/budget/MobileBudgetTable.js 📈 +7.29 kB (+11.55%) 63.11 kB → 70.4 kB
src/components/budget/util.ts 📈 +194 B (+8.19%) 2.31 kB → 2.5 kB
src/style/styles.ts 📈 +280 B (+6.48%) 4.22 kB → 4.5 kB
src/components/budget/BalanceWithCarryover.tsx 📈 +98 B (+5.85%) 1.64 kB → 1.73 kB
../loot-core/src/shared/months.ts 📈 +155 B (+1.76%) 8.61 kB → 8.76 kB
src/components/autocomplete/CategoryAutocomplete.tsx 📈 +75 B (+0.92%) 7.97 kB → 8.04 kB
src/components/tooltips.js 📈 +35 B (+0.32%) 10.77 kB → 10.81 kB
src/components/budget/rollover/TransferTooltip.tsx 📉 -13 B (-0.31%) 4.05 kB → 4.03 kB
src/components/budget/DynamicBudgetTable.js 📉 -302 B (-9.25%) 3.19 kB → 2.89 kB
src/components/budget/rollover/rollover-components.tsx 📉 -4.84 kB (-23.18%) 20.87 kB → 16.03 kB
src/components/budget/CategoryGroupsContext.js 🔥 -107 B (-100%) 107 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 45.69 kB → 51.77 kB (+6.08 kB) +13.31%
static/js/wide-components.chunk.js 125.89 kB → 126.63 kB (+758 B) +0.59%
static/js/main.js 1.12 MB → 1.12 MB (+319 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 29.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.78 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (+28 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/shared/months.ts 📈 +155 B (+1.76%) 8.61 kB → 8.76 kB
packages/loot-core/src/server/db/index.ts 📉 -36 B (-0.21%) 17.03 kB → 17 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (+28 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@joel-jeremy joel-jeremy changed the title Mobile balance cover/transfer Mobile balance cover/transfer/rollover overspending Oct 16, 2023
@youngcw
Copy link
Member

youngcw commented Oct 16, 2023

With this and the other mobile additions there is almost no dead space to click away from a dialog. If its possible it would be nice to not open a new dialog if there is one currently open, or at least only open if nothing or one of the same type is open.

The hit box (is that the right name?) for this new dialog seems weirdly big and includes part of the spent value section.

@joel-jeremy
Copy link
Contributor Author

@youngcw I have pushed an update to fix the hit boxes. As for the first comment, that should have already been addressed in #1781 once that gets merged.

@youngcw
Copy link
Member

youngcw commented Oct 19, 2023

Would it look better to have the "you can click me" underline match the color of the balance value? If we don't want to completely match the color then maybe just matching the dimmed "0" balance color would be nice since the bar really stands out when the balance is 0.

@joel-jeremy joel-jeremy force-pushed the mobile-balance-cover-transfer branch from cee56a2 to 1ba1519 Compare October 23, 2023 02:13
@joel-jeremy
Copy link
Contributor Author

The layout changes made here also fixed the mobile report mode alignment issue as a bonus: #1790

@joel-jeremy joel-jeremy linked an issue Oct 23, 2023 that may be closed by this pull request
[Bug]: wonky alignment mobile report budget #1790
Closed
1 task
@joel-jeremy joel-jeremy force-pushed the mobile-balance-cover-transfer branch from fbcbc04 to 867379f Compare October 28, 2023 18:20
@youngcw
Copy link
Member

youngcw commented Oct 28, 2023

With this and the other mobile additions there is almost no dead space to click away from a dialog.

@joel-jeremy this issue still isn't fixed. It is working for the name and budgeted edit views, but I can directly open the balance tooltip from those other two or vice versa.

@joel-jeremy
Copy link
Contributor Author

@youngcw Issue should now be fixed :)

@joel-jeremy joel-jeremy merged commit 7325153 into actualbudget:master Oct 30, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Oct 30, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@joel-jeremy
Mobile balance cover/transfer/rollover overspending (actualbudget#1802)
a1e5bee 
* Mobile balance cover/transfer

* Release notes

* Fix errors

* Cleanup

* Fix hit boxes and add line clamp

* Fix styling

* Prevent simultaneous field edits

* Use onPointerDown

* Remove balanceTooltip close effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngcw youngcw youngcw approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: wonky alignment mobile report budget
2 participants
@joel-jeremy @youngcw